Skip to content

Cleanup End to End test framework#625

Merged
github-actions[bot] merged 2 commits intollm-d:mainfrom
shmuelk:cleanup-e2e
Feb 16, 2026
Merged

Cleanup End to End test framework#625
github-actions[bot] merged 2 commits intollm-d:mainfrom
shmuelk:cleanup-e2e

Conversation

@shmuelk
Copy link
Collaborator

@shmuelk shmuelk commented Feb 16, 2026

This PR cleans up the "framework" used by the end to end tests.

In particular it:

  1. Deletes a duplicated load of the vLLM Simulator image
  2. Deletes a forced Pull of the images needed from the code. This code is not needed for two reasons:
    1. The Makefile target test-e2e has a pre-requisite target of image-pull, which runs a scripts that verifies that the needed images are in the local directory.
    2. The code causes a pull of images from the remote repository even if an image with the appropriate tag exists locally.

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Copy link
Collaborator

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nilig
Copy link
Collaborator

nilig commented Feb 16, 2026

/lgtm
/approve

@github-actions github-actions bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2026
@github-actions github-actions bot merged commit 7e0a84d into llm-d:main Feb 16, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in llm-d-inference-scheduler Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants