Skip to content

Cleanup End to End test framework #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
Feb 16, 2026
Merged

Cleanup End to End test framework #625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b4d8a9
Removed duplicated line of code
shmuelk Feb 16, 2026
836a04f
Images alreday pulled if needed via image-pull Makefile target
shmuelk Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions test/e2e/e2e_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ func setupK8sCluster() {
kindLoadImage(vllmSimImage)
kindLoadImage(eppImage)
kindLoadImage(sideCarImage)
kindLoadImage(vllmSimImage)
}

func kindLoadImage(image string) {
Expand All @@ -183,15 +182,6 @@ func kindLoadImage(image string) {
_, err := exec.LookPath(containerRuntime)
gomega.Expect(err).ShouldNot(gomega.HaveOccurred(), "Could not find %s in PATH", containerRuntime)

// Pull the image first to ensure it's available locally
ginkgo.By(fmt.Sprintf("Pulling image %s if not available locally", image))
pullCommand := exec.Command(containerRuntime, "pull", image)
pullSession, pullErr := gexec.Start(pullCommand, ginkgo.GinkgoWriter, ginkgo.GinkgoWriter)
if pullErr == nil {
// Wait for pull to complete, but don't fail if image already exists or can't be pulled
gomega.Eventually(pullSession).WithTimeout(600 * time.Second).Should(gexec.Exit())
}

saveArgs := []string{"save", "--output", target}
if containerRuntime == "docker" {
// The platform flag is required for docker save to work but it is an unsupported flag for podman
Expand Down