Conversation
|
/ok-to-test |
|
🚀 Kind E2E (full) triggered by |
|
🚀 OpenShift E2E — approve and run ( |
GPU Pre-flight Check ✅GPUs are available for e2e-openshift tests. Proceeding with deployment.
|
There was a problem hiding this comment.
Pull request overview
Refactors and hardens the developer/E2E deployment scripts by modularizing deploy/install.sh into focused deploy/lib/* helpers, and shifts e2e-only InferenceObjective management from the install flow into the scale-from-zero e2e suite.
Changes:
- Modularize deploy logic into
deploy/lib/*(CLI parsing, prereqs, orchestration, monitoring/scaler backends, llm-d/WVA deploy, cleanup, verification). - Update scale-from-zero e2e to apply/delete
InferenceObjectivevia Go fixtures when the CRD exists; update related docs accordingly. - Add
make lint-deploy-scripts/make smoke-deploy-scriptsand update deploy docs to reflect infra-first defaults (VA/HPA opt-in).
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/scale_from_zero_test.go | Applies InferenceObjective from e2e setup (and cleans up) when API exists. |
| test/e2e/README.md | Documents new e2e responsibility for InferenceObjective creation. |
| test/e2e/fixtures/inference_objective.go | Adds dynamic-client fixture to create/delete InferenceObjective. |
| Makefile | Adds deploy-script lint and smoke targets. |
| docs/developer-guide/troubleshooting.md | Updates troubleshooting guidance around InferenceObjective ownership. |
| docs/developer-guide/testing.md | Updates infra/e2e deployment notes for flow-control + InferenceObjective. |
| deploy/README.md | Updates environment variables and examples (VA/HPA opt-in; INFRA_ONLY usage). |
| deploy/openshift/install.sh | Refactors OpenShift plugin to reuse shared namespace loop + CA extraction helper. |
| deploy/lib/wait_helpers.sh | Adds shared retry/wait helpers for deploy scripts. |
| deploy/lib/verify.sh | Adds verification + deployment summary helpers. |
| deploy/lib/scaler_runtime.sh | Adds scaler backend runtime helpers (KEDA/adapter + APIService guard). |
| deploy/lib/prereqs.sh | Extracts prerequisite checks and interactive prompts. |
| deploy/lib/kube_like_adapter.sh | Adds Kubernetes-like environment adapter for shared functions. |
| deploy/lib/install_core.sh | Extracts main install orchestration from deploy/install.sh. |
| deploy/lib/infra_wva.sh | Adds shared WVA deploy helpers + shared namespace loop + OpenShift CA extraction helper. |
| deploy/lib/infra_scaler_backend.sh | Adds shared scaler-backend orchestration wrapper. |
| deploy/lib/infra_monitoring.sh | Adds shared monitoring orchestration + optional Grafana deploy. |
| deploy/lib/infra_llmd.sh | Adds shared llm-d deployment helpers and e2e infra-only behavior adjustments. |
| deploy/lib/discovery.sh | Adds discovery helpers (GPU type; InferencePool API group detection). |
| deploy/lib/deploy_prometheus_kube_stack.sh | Adds shared kube-prometheus-stack install/uninstall for kube-like envs. |
| deploy/lib/constants.sh | Centralizes shared constants/selectors/timeouts for deploy scripts. |
| deploy/lib/common.sh | Centralizes logging + utility helpers. |
| deploy/lib/cli.sh | Centralizes CLI help + argument parsing. |
| deploy/lib/cleanup.sh | Centralizes undeploy/cleanup logic and scaler backend teardown. |
| deploy/kubernetes/README.md | Updates Kubernetes deploy examples to opt-in VA/HPA and INFRA_ONLY. |
| deploy/kubernetes/install.sh | Refactors Kubernetes plugin to source shared kube-like helpers. |
| deploy/kind-emulator/setup.sh | Updates shebang for portability. |
| deploy/kind-emulator/README.md | Updates kind-emulator examples to opt-in VA/HPA and INFRA_ONLY. |
| deploy/kind-emulator/install.sh | Refactors kind-emulator plugin to reuse shared kube-like helpers in parts. |
| deploy/install.sh | Converts to a thin entrypoint sourcing deploy/lib/* and invoking main. |
| deploy/inference-objective-e2e.yaml | Clarifies when install applies this manifest (non-e2e scale-to-zero only). |
18711b9 to
3e60474
Compare
|
Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation. |
0596c5a to
ccd1a8b
Compare
|
/ok-to-test |
|
🚀 Kind E2E (full) triggered by |
|
🚀 OpenShift E2E — approve and run ( |
GPU Pre-flight Check ✅GPUs are available for e2e-openshift tests. Proceeding with deployment.
|
b0380ba to
48c6273
Compare
|
/ok-to-test |
|
🚀 Kind E2E (full) triggered by |
|
🚀 OpenShift E2E — approve and run ( |
|
pr is ready @lionelvillard PTAL, let's try to merge this asap as it's deployment. Had to rebase twice already today, so folks can work on top of it. Thanks. |
GPU Pre-flight Check ✅GPUs are available for e2e-openshift tests. Proceeding with deployment.
|
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
bb495ac to
2a8eaeb
Compare
|
/ok-to-test |
|
🚀 Kind E2E (full) triggered by |
|
🚀 OpenShift E2E — approve and run ( |
GPU Pre-flight Check ✅GPUs are available for e2e-openshift tests. Proceeding with deployment.
|
per #872
This pr cleans up/ hardens the deploy scripts for better readability and maintainability (mostly moving around code. For the most part no new functionality). These scripts are only used for e2es and dev purposes.
Local full emulated kind e2e run: