[RTG][LinearScanRegisterAllocation] Add error message to avoid silent failures#10581
Open
maerhart wants to merge 1 commit into
Open
[RTG][LinearScanRegisterAllocation] Add error message to avoid silent failures#10581maerhart wants to merge 1 commit into
maerhart wants to merge 1 commit into
Conversation
seldridge
approved these changes
Jun 3, 2026
Comment on lines
+186
to
+188
| auto diag = | ||
| user->emitError("operand must be defined by a constant-like " | ||
| "operation for folding, but is a block argument"); |
Member
There was a problem hiding this comment.
Nit: this may format for readability better as:
Suggested change
| auto diag = | |
| user->emitError("operand must be defined by a constant-like " | |
| "operation for folding, but is a block argument"); | |
| auto diag = | |
| user->emitError() << "operand must be defined by a constant-like operation for folding, but is a block argument"; |
Ditto below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.