[CombToSynth] Add a lowering for mod/div where rhs is constant#10584
Open
okekayode wants to merge 1 commit into
Open
[CombToSynth] Add a lowering for mod/div where rhs is constant#10584okekayode wants to merge 1 commit into
okekayode wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concerns #10569
In this PR we add lowerings for
comb.divu,comb.modu,comb.divs, andcomb.modsin the case that the RHS is a constant value. For the division operators , we utiliseUnsignedDivisionByConstantInfoandSignedDivisionByConstantInfoto replace the operation with magic multiplication, shifts, and adds. For modulo, we reuse the division lowering via x % k = x - ((x / k) * k) = remainderAssisted-by: claude: sonnet 4.6