Skip to content

[FIRRTL] Mux reduction #6410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[FIRRTL] Mux reduction #6410

wants to merge 4 commits into from

Conversation

darthscsi
Copy link
Contributor

This reduces multi-muxes with certain patterns of redundancy. This is a very abbreviated version of prime-implicant style coverings.

This can change the output value for an out-of-bounds index,

@darthscsi
Copy link
Contributor Author

Also, having index == 0 being input[last] is supper supper annoying.

@uenoku
Copy link
Member

uenoku commented Nov 11, 2023

Also, having index == 0 being input[last] is supper supper annoying.

I agree it's really annoying but this is consistent withfirrtl.mux and hw.array_create.

@darthscsi
Copy link
Contributor Author

Also, having index == 0 being input[last] is supper supper annoying.

I agree it's really annoying but this is consistent withfirrtl.mux and hw.array_create.

That doesn't mean we got those right either :)

Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants