[InferReadWrite] Update the heuristic to infer the enable signal #6862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prithayan
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
uenoku
reviewed
Mar 25, 2024
Comment on lines
+424
to
+432
| void getEnableDrivers(Value enable, llvm::SmallDenseSet<Value> &enableSet) { | ||
| while (auto src = getConnectSrc(enable)) { | ||
| if (!enableSet.insert(src).second) | ||
| return; | ||
| if (!isa_and_nonnull<WireOp>(src.getDefiningOp())) | ||
| return; | ||
| enable = src; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this is almost identical to what firrtl::getModuleScopedDriver provides. Can we use/extend that helper function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the heuristic to infer the enable signal drivers. Since temporary wires can be introduced by circt passes, the immediate
getConnectSrcis not enough to infer the enable signal that might also drive thewmode.Traverse the assignment chain to get all the temporary wires that can potentially drive the enable. Use the set to simplify the write mode expression.