[Calyx] LICM after Affine ParallelOp unrolling #8256
+321
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahanxie353
requested review from
rachitnigam,
cgyurgyik,
mikeurbach and
andrewb1999
as code owners
jiahanxie353
force-pushed
the
par-unroll-licm
branch
from
5ae9009 to
1d02ebf
Compare
cgyurgyik
reviewed
Feb 19, 2025
| return | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think a couple more simple unit tests would instill some confidence. Like, does this handle cases where a dependent write occurs after in the affine.for, e.g.,
affine.parallel 0 to 2 {
%i = affine.for 0 to 8 {
%1 = store 42, %a[%i];
%0 = load %a[0];
...
There was a problem hiding this comment.
This example breaks my code, thanks for bringing it up
There was a problem hiding this comment.
Spoke offline; I'll leave this to your discretion.
|
I've updated the implementation based on the reviews, thanks @cgyurgyik ! |
cgyurgyik
reviewed
Feb 20, 2025
cgyurgyik
approved these changes
Feb 21, 2025
… the same memref in the parallel regions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does LICM after unrolling
affine.paralleloperations in order to prevent potential memory access contentions.