Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CIRGen][Builtin][Neon] Lower neon_vsra_n_v and neon_vsraq_n_v #1326

Merged
merged 2 commits into from
Feb 11, 2025
Merged

[CIR][CIRGen][Builtin][Neon] Lower neon_vsra_n_v and neon_vsraq_n_v #1326

merged 2 commits into from
Feb 11, 2025

Conversation

FantasqueX
Copy link
Collaborator

Clang CGBuiltin Implementation:

clangir/clang/lib/CodeGen/CGBuiltin.cpp

Lines 9562 to 9566 in a7383c9

case NEON::BI__builtin_neon_vsra_n_v:
case NEON::BI__builtin_neon_vsraq_n_v:
Ops[0] = Builder.CreateBitCast(Ops[0], Ty);
Ops[1] = EmitNeonRShiftImm(Ops[1], Ops[2], Ty, usgn, "vsra_n");
return Builder.CreateAdd(Ops[0], Ops[1]);

Similar commit: f9dee67

Closes: #1325

@bcardosolopes bcardosolopes requested a review from ghehg February 10, 2025 10:56
bcardosolopes
bcardosolopes approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

bcardosolopes
bcardosolopes requested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs format fixing

@ghehg
Copy link
Collaborator

ghehg commented Feb 11, 2025

LGTM too, thanks for working on this.

@bcardosolopes bcardosolopes merged commit 37fab7c into llvm:main Feb 11, 2025
6 checks passed
@FantasqueX FantasqueX deleted the neon-vsra branch February 11, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@ghehg ghehg Awaiting requested review from ghehg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CIRGen support for BI__builtin_neon_vsra_n_v
3 participants
@FantasqueX @ghehg @bcardosolopes