-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIR][CIRGen] Add alignment attribute to AtomicCmpXchg #1327
Conversation
✅ With the latest revision this PR passed the C/C++ code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving. The code format checker is yelling; remember to reformat the code please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks a lot for helping my first PR for clangir. |
There is an
alignment
attribute in MLIR's LLVMIR Dialectclangir/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
Line 1880 in a7383c9
When Clang builds IR, it adds an alignment automatically
clangir/clang/lib/CodeGen/CGBuilder.h
Lines 168 to 177 in a7383c9
This PR does the same thing for ClangIR.
Closes: #1275