Skip to content

[llvm-lit] Show test output when combining -v or -a with -q #106668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[llvm-lit] Show test output when combining -v or -a with -q #106668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/utils/lit/lit/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@


def create_display(opts, tests, total_tests, workers):
if opts.quiet:
if opts.quiet and not (opts.showOutput or opts.showAllOutput):
return NopDisplay()

num_tests = len(tests)
Expand Down Expand Up @@ -97,6 +97,7 @@ def update(self, test):
show_result = (
test.isFailure()
or self.opts.showAllOutput
or self.opts.showOutput
or (not self.opts.quiet and not self.opts.succinct)
)
if show_result:
Expand Down
4 changes: 4 additions & 0 deletions llvm/utils/lit/tests/shtest-output-printing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
# RUN: not %{lit} -v %{inputs}/shtest-output-printing > %t.out
# RUN: FileCheck --input-file %t.out --match-full-lines %s
#
# Check that -q doesn't override -v
# RUN: not %{lit} -v -q %{inputs}/shtest-output-printing > %t.out
# RUN: FileCheck --input-file %t.out --match-full-lines %s
#
# END.

# CHECK: -- Testing: {{.*}}
Expand Down
Loading