[compiler-rt][RISCV] Initialize length only when __init_riscv_feature… #115449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_bits success That could give us a simple way to detect `__init_riscv_feature_bits` got fail. See also riscv-non-isa/riscv-c-api-doc#95
lenary
reviewed
Nov 8, 2024
Comment on lines
+370
to
+371
| __riscv_feature_bits.length = RISCV_FEATURE_BITS_LENGTH; | ||
| __riscv_vendor_feature_bits.length = RISCV_VENDOR_FEATURE_BITS_LENGTH; |
There was a problem hiding this comment.
This would work, but it might be more obvious if this was moved into initRISCVFeature, maybe where the other fields in the structure are being set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_bits success
That could give us a simple way to detect
__init_riscv_feature_bitsgot fail.See also riscv-non-isa/riscv-c-api-doc#95