-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[RISCV] Remove loads from fixed-vectors-extract.ll. NFC #122796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/minor comment.
%b = add <3 x i64> %a, %a | ||
%c = extractelement <3 x i64> %b, i32 %idx | ||
ret i64 %c | ||
} | ||
|
||
define i32 @extractelt_v32i32_idx(ptr %x, i32 zeroext %idx) nounwind { | ||
define i32 @extractelt_v32i32_idx(<32 x i32> %a, i32 zeroext %idx) nounwind { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you leave this one? It looks like the extra legalization makes this one a bit hard to follow.
@@ -765,29 +668,32 @@ define i32 @extractelt_v32i32_idx(ptr %x, i32 zeroext %idx) nounwind { | |||
; | |||
; RV64NOM-LABEL: extractelt_v32i32_idx: | |||
; RV64NOM: # %bb.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
These tests cases weren't trying to test load+extract. I believe they only used loads because fixed vector arguments weren't supported when they were written or they weren't copied from the structure of other tests that pre-date fixed vector argument support. Reduces diff from llvm#122671.
68ec34c
to
6395f6c
Compare
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/11931 Here is the relevant piece of the build log for the reference
|
These test cases weren't trying to test load+extract. I believe they only used loads because fixed vector arguments weren't supported when they were written or they weren't copied from the structure of other tests that pre-date fixed vector argument support.
Reduces diff from #122671.