Skip to content

[RISCV] Remove loads from single element fixed vector reduction tests. NFC #122808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

[RISCV] Remove loads from single element fixed vector reduction tests. NFC #122808

merged 1 commit into from
Jan 14, 2025

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Jan 13, 2025 •
edited
Loading

These tests weren't interested in the loads. Removing them reduces the diffs from #122671.

@topperc
[RISCV] Remove loads from single element fixed vector reduction tests…
55ba834 
…. NFC

These tests weren't interested in the loas. Removing them reduces the
diffs from llvm#122671.
@topperc topperc requested review from preames and lukel97 January 13, 2025 22:18
preames
preames approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@preames preames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Having the loads does remove a coupling with the call lowering potentially making certain cases harder to test, but in this case, I don't see any bad interactions here.

@topperc topperc merged commit d90a427 into llvm:main Jan 14, 2025
7 of 9 checks passed
@topperc topperc deleted the pr/reduction-loads branch January 14, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preames preames preames approved these changes

@lukel97 lukel97 Awaiting requested review from lukel97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topperc @preames