-
Notifications
You must be signed in to change notification settings - Fork 15.5k
[ASan] Mark recent integration tests as accordingly for MSVC #135889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: MacGyver Codilla (39otsu) ChangesBoth of these tests will cause an unsuccessful pass when using msvc.
Full diff: https://github.com/llvm/llvm-project/pull/135889.diff 2 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/fakeframe-right-redzone.cpp b/compiler-rt/test/asan/TestCases/fakeframe-right-redzone.cpp
index da1f5f2fb9789..6dd4bdaa02773 100644
--- a/compiler-rt/test/asan/TestCases/fakeframe-right-redzone.cpp
+++ b/compiler-rt/test/asan/TestCases/fakeframe-right-redzone.cpp
@@ -1,5 +1,6 @@
// RUN: %clangxx_asan -O0 %s -o %t && %env_asan_opts=detect_stack_use_after_return=1 not %run %t 2>&1 | FileCheck %s
// RUN: %clangxx_asan -O0 %s -o %t -fsanitize-address-use-after-return=always && not %run %t 2>&1 | FileCheck %s
+// UNSUPPORTED: MSVC
#include "defines.h"
#include <stdint.h>
diff --git a/compiler-rt/test/asan/TestCases/shadowed-stack-serialization.cpp b/compiler-rt/test/asan/TestCases/shadowed-stack-serialization.cpp
index 4018c097aed5a..6a88c3c9ea9be 100644
--- a/compiler-rt/test/asan/TestCases/shadowed-stack-serialization.cpp
+++ b/compiler-rt/test/asan/TestCases/shadowed-stack-serialization.cpp
@@ -1,5 +1,7 @@
// RUN: %clangxx_asan -O0 %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s
+// MSVC marks this as xfail because it doesn't generate the metadata to display the variable's location in source.
+// XFAIL: msvc
int main() {
int x;
|
| @@ -1,5 +1,6 @@ | |||
| // RUN: %clangxx_asan -O0 %s -o %t && %env_asan_opts=detect_stack_use_after_return=1 not %run %t 2>&1 | FileCheck %s | |||
| // RUN: %clangxx_asan -O0 %s -o %t -fsanitize-address-use-after-return=always && not %run %t 2>&1 | FileCheck %s | |||
| // UNSUPPORTED: MSVC | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: here msvc is capitalized (i.e. "MSVC") but in your other file it's not (i.e. "msvc").
It seems the codebase mostly uses the latter form. I recommend using the latter form in both files
|
LGTM |
Both of these tests will cause an unsuccessful pass when using msvc.
shadowed-stack-serialization.cpp- XFAIL due to the metadata not being generated.fakeframe-right-redzone.cpp- UNSUPPORTED due to the optimization limitations of the msvc compiler.