Skip to content

[clang] Shard out some small gtest binaries #138021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/unittests/Basic/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
add_clang_unittest(BasicTests
# Basic tests have few LLVM and Clang dependencies, so linking it as a
# distinct target enables faster iteration times at low cost.
add_distinct_clang_unittest(BasicTests
CharInfoTest.cpp
DarwinSDKInfoTest.cpp
DiagnosticTest.cpp
Expand Down
4 changes: 3 additions & 1 deletion clang/unittests/Format/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
add_clang_unittest(FormatTests
# Format tests have few LLVM and Clang dependencies, so linking it as a
# distinct target enables faster iteration times at low cost.
add_distinct_clang_unittest(FormatTests
BracesInserterTest.cpp
BracesRemoverTest.cpp
CleanupTest.cpp
Expand Down
4 changes: 3 additions & 1 deletion clang/unittests/libclang/CrashTests/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
add_clang_unittest(libclangCrashTests
# FIXME(#137855): Ideally we'd fold this into AllClangUnitTests, but it fails
# for unknown reasons. Until that is fixed, link it as a distinct gtest binary.
add_distinct_clang_unittest(libclangCrashTests
LibclangCrashTest.cpp
LINK_LIBS
libclang
Expand Down
3 changes: 1 addition & 2 deletions clang/unittests/libclang/CrashTests/LibclangCrashTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ TEST_F(LibclangParseTest, InstallAbortingLLVMFatalErrorHandler) {
"");
}

// FIXME: Re-enable after Mac-AArch64 signpost crash issues are debugged.
TEST_F(LibclangParseTest, DISABLED_UninstallAbortingLLVMFatalErrorHandler) {
TEST_F(LibclangParseTest, UninstallAbortingLLVMFatalErrorHandler) {
clang_toggleCrashRecovery(0);
clang_install_aborting_llvm_fatal_error_handler();
clang_uninstall_llvm_fatal_error_handler();
Expand Down