-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[sanitizer_common] Implement address sanitizer on AIX: stack unwinding #138188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,66 @@ | ||||||||
//===-- sanitizer_unwind_aix.cpp ------------------------------------------===// | ||||||||
// | ||||||||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||||||||
// See https://llvm.org/LICENSE.txt for license information. | ||||||||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||||||||
// | ||||||||
//===----------------------------------------------------------------------===// | ||||||||
// | ||||||||
// This file contains the unwind.h-based (aka "slow") stack unwinding routines | ||||||||
// available to the tools on AIX. | ||||||||
//===----------------------------------------------------------------------===// | ||||||||
|
||||||||
#include "sanitizer_platform.h" | ||||||||
|
||||||||
#if SANITIZER_AIX | ||||||||
# include <unwind.h> | ||||||||
|
||||||||
# include "sanitizer_common.h" | ||||||||
# include "sanitizer_stacktrace.h" | ||||||||
|
||||||||
namespace __sanitizer { | ||||||||
|
||||||||
struct UnwindTraceArg { | ||||||||
BufferedStackTrace *stack; | ||||||||
u32 max_depth; | ||||||||
}; | ||||||||
|
||||||||
_Unwind_Reason_Code Unwind_Trace(struct _Unwind_Context *ctx, void *param) { | ||||||||
UnwindTraceArg *arg = (UnwindTraceArg *)param; | ||||||||
CHECK_LT(arg->stack->size, arg->max_depth); | ||||||||
uptr pc = _Unwind_GetIP(ctx); | ||||||||
// On AIX 32-bit and 64-bit, address smaller than 0x0fffffff is for kernel. | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment wording should match use of
Suggested change
|
||||||||
if (pc <= 0x0fffffff) | ||||||||
return _URC_NORMAL_STOP; | ||||||||
arg->stack->trace_buffer[arg->stack->size++] = pc; | ||||||||
if (arg->stack->size == arg->max_depth) | ||||||||
return _URC_NORMAL_STOP; | ||||||||
return _URC_NO_REASON; | ||||||||
} | ||||||||
|
||||||||
void BufferedStackTrace::UnwindSlow(uptr pc, u32 max_depth) { | ||||||||
CHECK_GE(max_depth, 2); | ||||||||
size = 0; | ||||||||
UnwindTraceArg arg = {this, Min(max_depth + 1, kStackTraceMax)}; | ||||||||
_Unwind_Backtrace(Unwind_Trace, &arg); | ||||||||
// We need to pop a few frames so that pc is on top. | ||||||||
uptr to_pop = LocatePcInTrace(pc); | ||||||||
// trace_buffer[0] belongs to the current function so we always pop it, | ||||||||
// unless there is only 1 frame in the stack trace (1 frame is always better | ||||||||
// than 0!). | ||||||||
// 1-frame stacks don't normally happen, but this depends on the actual | ||||||||
// unwinder implementation (libgcc, libunwind, etc) which is outside of our | ||||||||
// control. | ||||||||
if (to_pop == 0 && size > 1) | ||||||||
to_pop = 1; | ||||||||
|
||||||||
PopStackFrames(to_pop); | ||||||||
trace_buffer[0] = pc; | ||||||||
} | ||||||||
|
||||||||
void BufferedStackTrace::UnwindSlow(uptr pc, void *context, u32 max_depth) { | ||||||||
UnwindSlow(pc, max_depth); | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's enforce the interface preconditions even if they are currently harmless to ignore. This conveniently removes any possible warnings that
Suggested change
|
||||||||
} | ||||||||
} // namespace __sanitizer | ||||||||
|
||||||||
#endif // SANITIZER_AIX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this function can be static?