Skip to content

[CMake] Turn on LLVM_ENABLE_BACKTRACE for Apple stage1 compiler #141872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Collaborator

Stage1 compiler is mostly what is used in CI for running tests and
bootstrapping compiler. Printing backtrace on crash will make CI
output much more readable and help us diagnose the issue without
spending time to reproduce the build first.

Created using spr 1.3.6
@llvmbot llvmbot added the clang Clang issues not falling into any other category label May 28, 2025
@llvmbot
Copy link
Member

llvmbot commented May 28, 2025

@llvm/pr-subscribers-clang

Author: Steven Wu (cachemeifyoucan)

Changes

Stage1 compiler is mostly what is used in CI for running tests and
bootstrapping compiler. Printing backtrace on crash will make CI
output much more readable and help us diagnose the issue without
spending time to reproduce the build first.


Full diff: https://github.com/llvm/llvm-project/pull/141872.diff

1 Files Affected:

  • (modified) clang/cmake/caches/Apple-stage1.cmake (+1-1)
diff --git a/clang/cmake/caches/Apple-stage1.cmake b/clang/cmake/caches/Apple-stage1.cmake
index 8a4fe6dfdfdf8..36937f6ed0b4b 100644
--- a/clang/cmake/caches/Apple-stage1.cmake
+++ b/clang/cmake/caches/Apple-stage1.cmake
@@ -18,7 +18,7 @@ set(COMPILER_RT_INCLUDE_TESTS OFF CACHE BOOL "")
 set(COMPILER_RT_BUILD_SANITIZERS OFF CACHE BOOL "")
 set(CMAKE_MACOSX_RPATH ON CACHE BOOL "")
 set(LLVM_ENABLE_ZLIB OFF CACHE BOOL "")
-set(LLVM_ENABLE_BACKTRACES OFF CACHE BOOL "")
+set(LLVM_ENABLE_BACKTRACES ON CACHE BOOL "")
 set(CLANG_PLUGIN_SUPPORT OFF CACHE BOOL "")
 set(CLANG_SPAWN_CC1 ON CACHE BOOL "")
 set(CLANG_BOOTSTRAP_PASSTHROUGH

@cachemeifyoucan cachemeifyoucan merged commit 2c9a727 into main May 29, 2025
11 of 12 checks passed
@cachemeifyoucan cachemeifyoucan deleted the users/cachemeifyoucan/spr/cmake-turn-on-llvm_enable_backtrace-for-apple-stage1-compiler branch May 29, 2025 00:32
google-yfyang pushed a commit to google-yfyang/llvm-project that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants