[libclc] Suppress AMDGCN code object version for library code #174412
Conversation
Summary: The code object version defines the ABI the HSA executables follow. This prevents it from hard-coding it in the OpenCL libraries and preventing users from overriding it when using them.
| endif() | ||
| elseif( ARCH STREQUAL amdgcn ) | ||
| set( build_flags "SHELL:-Xclang -mcode-object-version=none" ) | ||
| set( opt_flags -O3 ) |
There was a problem hiding this comment.
The opt level probably shouldn't be coming from each target
There was a problem hiding this comment.
I was just following the existing form, I could do more refactorings if you want but the libclc CMake is kind of convoluted due to the lack of using any normal CMake support.
arsenm
left a comment
arsenm
left a comment
There was a problem hiding this comment.
Ideally we would be able to base this on the triple (failing total removal of the flag). It's not great to spread the clang internal flags around, but given this is an internal project anyway it's tolerable and we do it for other flags already
We expose |
…74412) Summary: The code object version defines the ABI the HSA executables follow. This prevents it from hard-coding it in the OpenCL libraries and preventing users from overriding it when using them.
3 participants
Summary:
The code object version defines the ABI the HSA executables follow. This
prevents it from hard-coding it in the OpenCL libraries and preventing
users from overriding it when using them.