[Clang] Disable verifier passes by default in NewPM CodeGen#208178
Merged
aengelke merged 1 commit intoJul 8, 2026
Merged
Conversation
Created using spr 1.3.8-wip
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Alexis Engelke (aengelke) ChangesBy default, we shouldn't add expensive verifier passes to the pipeline. Full diff: https://github.com/llvm/llvm-project/pull/208178.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/BackendUtil.cpp b/clang/lib/CodeGen/BackendUtil.cpp
index e33480f6c6416..f33026426e815 100644
--- a/clang/lib/CodeGen/BackendUtil.cpp
+++ b/clang/lib/CodeGen/BackendUtil.cpp
@@ -1301,6 +1301,7 @@ void EmitAssemblyHelper::RunCodegenPipelineNewPM(
CGSCCAnalysisManager CGAM;
ModuleAnalysisManager MAM;
CGPassBuilderOption Opt = getCGPassBuilderOption();
+ Opt.DisableVerify = !CodeGenOpts.VerifyModule;
MachineModuleInfo MMI(TM.get());
PassInstrumentationCallbacks PIC;
PipelineTuningOptions PTOptions;
|
oontvoo
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, we shouldn't add expensive verifier passes to the pipeline.
This causes a substantial perf regression compared to the legacy PM.