Skip to content

[libc++][ranges][NFC] Format a couple of elements_view tests - #210687

Merged
Zingam merged 1 commit into
llvm:mainfrom
H-G-Hristov:hgh/libcxx/elements_view-tests-format
Jul 20, 2026
Merged

[libc++][ranges][NFC] Format a couple of elements_view tests#210687
Zingam merged 1 commit into
llvm:mainfrom
H-G-Hristov:hgh/libcxx/elements_view-tests-format

Conversation

@H-G-Hristov

Copy link
Copy Markdown
Contributor

As a pre-requisite for #193891

@H-G-Hristov
H-G-Hristov requested a review from a team as a code owner July 20, 2026 11:17
@llvmorg-github-actions llvmorg-github-actions Bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jul 20, 2026
@llvmorg-github-actions

Copy link
Copy Markdown

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

Changes

As a pre-requisite for #193891


Full diff: https://github.com/llvm/llvm-project/pull/210687.diff

2 Files Affected:

  • (modified) libcxx/test/std/ranges/range.adaptors/range.elements/iterator/base.pass.cpp (+3-4)
  • (modified) libcxx/test/std/ranges/range.adaptors/range.elements/sentinel/ctor.convert.pass.cpp (+3-3)
diff --git a/libcxx/test/std/ranges/range.adaptors/range.elements/iterator/base.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.elements/iterator/base.pass.cpp
index 79c4e1f418372..a77e98f845a06 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.elements/iterator/base.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.elements/iterator/base.pass.cpp
@@ -22,10 +22,9 @@
 
 // Test Noexcept
 template <class T>
-concept IsBaseNoexcept =
-    requires {
-      { std::declval<T>().base() } noexcept;
-    };
+concept IsBaseNoexcept = requires {
+  { std::declval<T>().base() } noexcept;
+};
 
 using BaseView     = std::ranges::subrange<std::tuple<int>*>;
 using ElementsIter = std::ranges::iterator_t<std::ranges::elements_view<BaseView, 0>>;
diff --git a/libcxx/test/std/ranges/range.adaptors/range.elements/sentinel/ctor.convert.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.elements/sentinel/ctor.convert.pass.cpp
index 4ff65be645220..96019b74a2d02 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.elements/sentinel/ctor.convert.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.elements/sentinel/ctor.convert.pass.cpp
@@ -60,9 +60,9 @@ static_assert(!std::is_constructible_v<std::ranges::sentinel_t<std::ranges::elem
                                        std::ranges::sentinel_t<const std::ranges::elements_view<Range, 0>>>);
 
 // !convertible_to<sentinel_t<V>, sentinel_t<Base>>
-static_assert(!std::is_constructible_v<
-              std::ranges::sentinel_t<const std::ranges::elements_view<NonConvertConstSentRange, 0>>,
-              std::ranges::sentinel_t<std::ranges::elements_view<NonConvertConstSentRange, 0>>>);
+static_assert(
+    !std::is_constructible_v< std::ranges::sentinel_t<const std::ranges::elements_view<NonConvertConstSentRange, 0>>,
+                              std::ranges::sentinel_t<std::ranges::elements_view<NonConvertConstSentRange, 0>>>);
 
 constexpr bool test() {
   // base is init correctly

@H-G-Hristov
H-G-Hristov force-pushed the hgh/libcxx/elements_view-tests-format branch from 194eff9 to 67da176 Compare July 20, 2026 11:18
@Zingam Zingam added the ranges Issues related to `<ranges>` label Jul 20, 2026
@Zingam Zingam changed the title [libc++][ranges][NFC] Format a few elements_view tests [libc++][ranges][NFC] Format a couple of elements_view tests Jul 20, 2026
@ldionne ldionne added the pending-ci Merging the PR is only pending completion of CI label Jul 20, 2026
@Zingam
Zingam merged commit 8d5788c into llvm:main Jul 20, 2026
84 checks passed
@ldionne ldionne removed the pending-ci Merging the PR is only pending completion of CI label Jul 21, 2026
@H-G-Hristov
H-G-Hristov deleted the hgh/libcxx/elements_view-tests-format branch July 22, 2026 18:11
midhuncodes7 pushed a commit to midhuncodes7/llvm-project that referenced this pull request Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. ranges Issues related to `<ranges>`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants