Skip to content

[RegAllocFast] Assert that isTiedToNotUndef() takes a def. NFC #221120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaskRay wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −8
Open

[RegAllocFast] Assert that isTiedToNotUndef() takes a def. NFC #221120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions llvm/lib/CodeGen/RegAllocFast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,12 +704,10 @@ void RegAllocFastImpl::reloadAtBegin(MachineBasicBlock &MBB) {
if (LiveVirtRegs.empty())
return;

for (MachineBasicBlock::RegisterMaskPair P : MBB.liveins()) {
MCRegister Reg = P.PhysReg;
// Set state to live-in. This possibly overrides mappings to virtual
// registers but we don't care anymore at this point.
setPhysRegState(Reg, regLiveIn);
}
// Set state to live-in. This possibly overrides mappings to virtual
// registers but we don't care anymore at this point.
for (MachineBasicBlock::RegisterMaskPair P : MBB.liveins())
setPhysRegState(P.PhysReg, regLiveIn);

SmallSet<Register, 2> PrologLiveIns;

Expand Down Expand Up @@ -1454,9 +1452,10 @@ void RegAllocFastImpl::findAndSortDefOperandIndexes(const MachineInstr &MI) {
});
}

// Returns true if MO is tied and the operand it's tied to is not Undef (not
// Undef is not the same thing as Def).
// Returns true if this def (MO) ties to a use that actually carries a value
// (not undef).
static bool isTiedToNotUndef(const MachineInstr &MI, const MachineOperand &MO) {
assert(MO.isDef() && "expected a def operand");
if (!MO.isTied())
return false;
unsigned TiedIdx = MI.findTiedOperandIdx(MI.getOperandNo(&MO));
Expand Down
Loading