Skip to content

[MIR] Support +inf and -inf literals - #221127

Open
Inconnu08 wants to merge 1 commit into
llvm:mainfrom
Inconnu08:fix-mir-inf-literals
Open

[MIR] Support +inf and -inf literals#221127
Inconnu08 wants to merge 1 commit into
llvm:mainfrom
Inconnu08:fix-mir-inf-literals

Conversation

@Inconnu08

@Inconnu08 Inconnu08 commented Sep 4, 2026

Copy link
Copy Markdown

Support parsing +inf and -inf as floating-point literals in MIR.

The MIR lexer previously tokenized the leading sign separately, causing
G_FCONSTANT float +inf and G_FCONSTANT float -inf to fail with
"expected a floating point literal".

Recognize signed infinity spellings as FloatingPointLiteral tokens so
they can be handled by the existing floating-point constant parsing path.

Add a regression test covering both positive and negative infinity.

Fixes #221040

Assisted-by: ChatGPT (rubber ducking)

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Hello @Inconnu08 👋

Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.

  • All contributions to LLVM must follow our LLVM AI Tool Use Policy. In particular, if you used AI while working on this PR, remember to add a note to the PR description.
  • The LLVM Code-Review Policy and Practices document contains practical information about the PR process, including how patches are reviewed and accepted, and who can review a PR.
  • Our LLVM Developer Policy describes our expectations for code quality, commit summaries and contains notes on our CI system.

Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description.


Frequently asked questions

How do I add reviewers?

This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically.

You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using @ followed by their GitHub username.

What if there are no comments?

If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers.

Are any special GitHub settings required to contribute to LLVM?

We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details.


If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse.

Thank you,
The LLVM Community

@Inconnu08

Copy link
Copy Markdown
Author

I've read the LLVM AI Tool Use Policy and the linked contribution policies. AI assistance has been disclosed in the PR description, and I've reviewed, tested, and understand the submitted changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support +inf and -inf literals in MIR parser.

1 participant