[C++20] [Modules] Identify the tag redecl through Using - #221147
Open
ChuanqiXu9 wants to merge 1 commit into
Open
[C++20] [Modules] Identify the tag redecl through Using#221147ChuanqiXu9 wants to merge 1 commit into
ChuanqiXu9 wants to merge 1 commit into
Conversation
Close llvm#96423 We've already have some logics to merge the redecls. But if the previous decls are found through using decl, we can't merge them right now. As the reproducer shows. The using decl is common in modules as a common method to wrap headers into a module. The fix is simple too. If the existing check fails, we'll check if the found one is a using decl, if yes, we will reuse the existing check with the target decl for using decl.
ChuanqiXu9
added
clang:modules
llvmorg-github-actions
Bot
added
clang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #96423
We've already have some logics to merge the redecls. But if the previous decls are found through using decl, we can't merge them right now. As the reproducer shows. The using decl is common in modules as a common method to wrap headers into a module.
The fix is simple too. If the existing check fails, we'll check if the found one is a using decl, if yes, we will reuse the existing check with the target decl for using decl.