[flang] Fix typos PPC intrinsics tests (NFC) #92943
Conversation
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-fir-hlfir Author: Kelvin Li (kkwli) ChangesSee #92387 (comment) Full diff: https://github.com/llvm/llvm-project/pull/92943.diff 2 Files Affected:
diff --git a/flang/test/Lower/PowerPC/ppc-vec-load.f90 b/flang/test/Lower/PowerPC/ppc-vec-load.f90
index 4d51512df0f7b..61f18a79cf901 100644
--- a/flang/test/Lower/PowerPC/ppc-vec-load.f90
+++ b/flang/test/Lower/PowerPC/ppc-vec-load.f90
@@ -1,4 +1,5 @@
! RUN: %flang_fc1 -flang-experimental-hlfir -triple powerpc64le-unknown-unknown -emit-llvm %s -o - | FileCheck --check-prefixes="LLVMIR","LLVMIR-LE" %s
+! RUN: %flang_fc1 -triple powerpc64le-unknown-unknown -target-cpu pwr9 -emit-llvm %s -o - | FileCheck --check-prefixes="LLVMIR","LLVMIR_P9" %s
! RUN: %flang_fc1 -flang-experimental-hlfir -triple powerpc64-unknown-unknown -emit-llvm %s -o - | FileCheck --check-prefixes="LLVMIR","LLVMIR-BE" %s
! REQUIRES: target=powerpc{{.*}}
diff --git a/flang/test/Lower/PowerPC/ppc-vec-shift-be-le.f90 b/flang/test/Lower/PowerPC/ppc-vec-shift-be-le.f90
index bd83f28b4eeb5..61dc9d08b1a02 100644
--- a/flang/test/Lower/PowerPC/ppc-vec-shift-be-le.f90
+++ b/flang/test/Lower/PowerPC/ppc-vec-shift-be-le.f90
@@ -1,4 +1,4 @@
-! RUN: %flang_fc1 -flang-experimental-hlfir -emit-llvm %s -triple ppc64le-unknown-linux -o - | FileCheck --check-prefixes="CHECK" %s
+! RUN: %flang_fc1 -flang-experimental-hlfir -emit-llvm %s -triple ppc64le-unknown-linux -o - | FileCheck --check-prefixes="LLVMIR" %s
!
! RUN: %flang_fc1 -flang-experimental-hlfir -emit-llvm %s -triple ppc64-unknown-aix -o - | FileCheck --check-prefixes="BE-LLVMIR" %s
! REQUIRES: target=powerpc{{.*}}
|
| ! RUN: %flang_fc1 -flang-experimental-hlfir -emit-llvm %s -triple ppc64le-unknown-linux -o - | FileCheck --check-prefixes="CHECK" %s | ||
| ! RUN: %flang_fc1 -flang-experimental-hlfir -emit-llvm %s -triple ppc64le-unknown-linux -o - | FileCheck --check-prefixes="LLVMIR" %s |
There was a problem hiding this comment.
Isn't this makes CHECK prefixes unused? For example, on 10 line.
There was a problem hiding this comment.
Yes, you're right. I will update it. Thanks.
There was a problem hiding this comment.
While currently CHECK-LABEL is allowed check prefix, this soon can be not (#92735). Plus this converts https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-label-directive to simple prefix(or not? Linked pr should fix that).
There was a problem hiding this comment.
Thanks for the heads up. I think I'd better use another prefix.
There was a problem hiding this comment.
I'm losing confidence in my understanding how different prefixes works between them: in case of
FOO-LABEL: xxx
BAR: yyy
...
FOO2-LABEL: zzz
will BAR me matched between FOO and FOO2 or not? idk.
Anyway, in 76100a9 you defined prefixes ending with -LABEL, but they should be LLVM, i guess. So you need to change only definitions.
There was a problem hiding this comment.
Anyway, in 76100a9 you defined prefixes ending with
-LABEL, but they should beLLVM, i guess. So you need to change only definitions
Sorry, I don't quite understand. Did you mean if I specify LLVM in --check-prefixes, LLVM-LABEL will be effective?
There was a problem hiding this comment.
Yes, this should start working as directive LABEL, if i understand correct.
There was a problem hiding this comment.
Thanks. I push a commit to fix that.
|
@klensy Thanks for the review. Do you have any further comment? If not, I will merge it. |
Ok, should be good now. |
Thanks for the review. |
See #92387 (comment)