add workflow to test against multiple aws-cdk versions #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzon
force-pushed
the
workflow-cdk-version
branch
2 times, most recently
from
7dc1aec to
1159e3b
Compare
pinzon
changed the title
pinzon
force-pushed
the
workflow-cdk-version
branch
from
d226916 to
c739659
Compare
Member
Author
|
That PR fixed all the failing checks. @dominikschubert |
dominikschubert
requested changes
Dec 9, 2024
Member
dominikschubert
left a comment
dominikschubert
left a comment
There was a problem hiding this comment.
We should definitely also test a few of the 1.x versions as well. It would also be great if by default we would limit this as discussed to a set of predefined versions and only execute the full list on-demand.
dominikschubert
force-pushed
the
workflow-cdk-version
branch
from
1e83f83 to
4dc26a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a GitHub workflow which main objective is to test the our aws-cdk-local tool agains multiple aws-cdk versions by simply creating a new python project and deploying it in LS.
Explanation
The workflows consists in 2 jobs:
generate-cdk-versions-matrixwhich objective is to pull the list of versions available ofaws-cdkand generate a strategy matrix. By default it just gives a list of 11 versions (including latest) manually selected.version-testinggrabs the matrix and per each version, installs the CDK lib version, creates a project and tries to deploy it to LS.Notes
The matrix is limited to 256 items due to GH limits.