Skip to content

fix: document bi-directionality of secret stores #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

johannesfrey
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind documentation

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
part of ENG-6260

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster docs where unclear about SecretStore sync bi-directionality

What else do we need to know?

@johannesfrey johannesfrey requested a review from a team as a code owner April 9, 2025 07:20
Copy link

netlify bot commented Apr 9, 2025

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit fa8ab58
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/67f67ff9fd2b4d00089e9465

@johannesfrey johannesfrey force-pushed the correct-secret-store-comments branch from 0e61a34 to 7702747 Compare April 9, 2025 07:40
@johannesfrey johannesfrey force-pushed the correct-secret-store-comments branch from eb59449 to fa8ab58 Compare April 9, 2025 14:11
Copy link
Contributor

@zerbitx zerbitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johannesfrey johannesfrey merged commit 1c55321 into loft-sh:main Apr 22, 2025
60 of 61 checks passed
@loft-bot
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
v0.24

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants