Skip to content

bugfix: disallow users from creating a vCluster in the platform namespace #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neogopher
Copy link
Contributor

@neogopher neogopher commented May 12, 2025

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-5603

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster was allowed to be installed in the platform namespace

What else do we need to know?

Test Results:

Helm

  1. When the platform installation exists, and the helm command is targeted towards the same namespace, it throws an error and exits.
    image
  2. When the helm install is targeted to a different namespace, it proceeds correctly.
    image

vCluster CLI

  1. When the platform installation exists, and the CLI command is targeted towards the same namespace, it throws an error and exits.
    image
  2. When the command is targeted towards a different namespace, it proceeds correctly.
    image

@neogopher neogopher force-pushed the bugfix-vcluster-in-platform-namespace branch 4 times, most recently from 44c1854 to 079b5cf Compare May 13, 2025 08:37
@neogopher neogopher force-pushed the bugfix-vcluster-in-platform-namespace branch from 079b5cf to 47cc941 Compare May 13, 2025 09:28
@neogopher neogopher marked this pull request as ready for review May 13, 2025 10:01
@neogopher neogopher requested a review from a team as a code owner May 13, 2025 10:01
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hidalgopl hidalgopl merged commit f0de104 into loft-sh:main May 20, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants