fix(PeerManager): SelectRandom filter by protocol #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
requested review from
chaitanyaprem and
richard-ramos
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
filterprotocol to the bootstrap node that does not support it status-im/status-go#7097Description
If
filteredPeerswere empty, thenPeersByPubSubTopicswould use all known peers:https://github.com/waku-org/go-waku/blob/8ff8779bb06c444386ff863aa052a69a8cfba862/waku/v2/peerstore/waku_peer_store.go#L228-L231
... which would effectively removes filtering by protocol.
Also:
selectWithLowestRTTtest part to the end, as it modifies hosts protocols and breaks other testsselectRandomPeers, which incorrectly calculatescount:logos-messaging-go/waku/v2/peermanager/peer_selection.go
Line 79 in 84a4b1b