fix: hash inputs for external nullifier, remove length prefix for sha256 #3660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adklempner
force-pushed
the
fix/rln-hashing
branch
from
35a8381 to
eb52727
Compare
adklempner
force-pushed
the
fix/rln-hashing
branch
from
eb52727 to
b503bf1
Compare
darshankabariya
requested review from
Ivansete-status,
darshankabariya and
stubbsta
darshankabariya
approved these changes
Dec 11, 2025
Contributor
darshankabariya
left a comment
darshankabariya
left a comment
There was a problem hiding this comment.
Looks good! Just need to wait for the CI since it’s breaking due to the renames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When generating an external nullifier for RLN proofs, the epoch and rln identifier values need to be hashed using sha256 before being hashed via poseidon in order to ensure that the two values match the field element used by zerokit.
Changes
sha256wrapper when generating or extracting the external nullifier:sha256wrapperIssue
related to logos-messaging/js-waku#2746