Skip to content

fix: hash inputs for external nullifier, remove length prefix for sha256 #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adklempner wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: hash inputs for external nullifier, remove length prefix for sha256 #3660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions waku/waku_rln_relay/group_manager/on_chain/group_manager.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,11 @@ method generateProof*(

let x = keccak.keccak256.digest(data)

let extNullifier = poseidon(@[@(epoch), @(rlnIdentifier)]).valueOr:
let epochHash = sha256(@(epoch)).valueOr:
return err("Failed to compute epoch hash: " & error)
let rlnIdentifierHash = sha256(@(rlnIdentifier)).valueOr:
return err("Failed to compute rln identifier hash: " & error)
let extNullifier = poseidon(@[@(epochHash), @(rlnIdentifierHash)]).valueOr:
return err("Failed to compute external nullifier: " & error)

let witness = RLNWitnessInput(
Expand Down Expand Up @@ -457,10 +461,15 @@ method verifyProof*(

var normalizedProof = proof

normalizedProof.externalNullifier = poseidon(
@[@(proof.epoch), @(proof.rlnIdentifier)]
).valueOr:
return err("Failed to compute external nullifier: " & error)
let epochHash = sha256(@(proof.epoch)).valueOr:
return err("Failed to compute epoch hash: " & error)
let rlnIdentifierHash = sha256(@(proof.rlnIdentifier)).valueOr:
return err("Failed to compute rln identifier hash: " & error)
let externalNullifier = poseidon(
@[@(epochHash), @(rlnIdentifierHash)]
).valueOr:
return err("Failed to compute external nullifier: " & error)
normalizedProof.externalNullifier = externalNullifier

let proofBytes = serialize(normalizedProof, input)
let proofBuffer = proofBytes.toBuffer()
Expand Down
13 changes: 9 additions & 4 deletions waku/waku_rln_relay/rln/wrappers.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,8 @@ proc createRLNInstance*(): RLNResult =

proc sha256*(data: openArray[byte]): RlnRelayResult[MerkleNode] =
## a thin layer on top of the Nim wrapper of the sha256 hasher
var lenPrefData = encodeLengthPrefix(data)
var
hashInputBuffer = lenPrefData.toBuffer()
hashInputBuffer = data.toBuffer()
outputBuffer: Buffer # will holds the hash output

trace "sha256 hash input buffer length", bufflen = hashInputBuffer.len
Expand Down Expand Up @@ -181,8 +180,14 @@ proc toLeaves*(rateCommitments: seq[RateCommitment]): RlnRelayResult[seq[seq[byt
return ok(leaves)

proc extractMetadata*(proof: RateLimitProof): RlnRelayResult[ProofMetadata] =
let externalNullifier = poseidon(@[@(proof.epoch), @(proof.rlnIdentifier)]).valueOr:
return err("could not construct the external nullifier")
let epochHash = sha256(@(proof.epoch)).valueOr:
return err("Failed to compute epoch hash: " & error)
let rlnIdentifierHash = sha256(@(proof.rlnIdentifier)).valueOr:
return err("Failed to compute rln identifier hash: " & error)
let externalNullifier = poseidon(
@[@(epochHash), @(rlnIdentifierHash)]
).valueOr:
return err("Failed to compute external nullifier: " & error)
return ok(
ProofMetadata(
nullifier: proof.nullifier,
Expand Down