ci: fix release-please versioning config key - #261
Merged
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
Fixes the Release Please configuration so the prerelease versioning strategy is actually applied (Release Please reads versioning, and silently ignores unknown keys like versioning-strategy), enabling the release PR to refresh to 3.0.0-beta as intended.
Changes:
- Replace the incorrect
versioning-strategyconfig key with the correctversioningkey inrelease-please-config.json.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charIeszhao
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #257, which had no effect: the manifest config key for the versioning strategy is
versioning, notversioning-strategy(seemanifest.ts—versioning: config['versioning']; unknown keys are silently ignored). That's why the post-merge run loggedPR #245 remained the sameinstead of refreshing it to3.0.0-beta.With the correct key, the merge push of this PR will trigger release-please to recompute and retitle #245 to
release: 3.0.0-beta.Testing
N/A (verified against release-please source and the run log; will be exercised by the merge push of this PR)
Checklist
.changeset(N/A — this repo uses release-please)🤖 Generated with Claude Code