fix(pocketMoney): Add Money button does nothing#105
Merged
Conversation
defaultValues.date was '', which failed the Zod dd-mm-yyyy regex before handleSubmit could inject getTodayDate(). The form had no UI to render the resulting errors.date, so clicking Add Money silently did nothing. Default to today's date up front (and on reset) — the handler still re-injects today on submit.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultValues.datewas an empty string. The Zod schema requiresdd-mm-yyyy, so RHF'shandleSubmitfailed validation before the inner handler could injectgetTodayDate(). The form has no UI for the date field, soerrors.datewas silently set and clicking "Add Money" appeared to do nothing.Seed
defaultValues.date(and the post-successreset()) withgetTodayDate(). Handler still re-injects today on submit, so a form left open past midnight still posts the correct date.Test plan