This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Updated for meteor 1.3 / 1.4 closes #71 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 19, 2016 10:08
| // since meteor 1.3 we no longer need meteor hacks just use the npm version | ||
| if (minorVersion >= 3){ | ||
| sass = require('node-sass'); | ||
| } else if (!Package['chrisbutler:node-sass']) { |
There was a problem hiding this comment.
Shouldn't this be else if (Package['chrisbutler:node-sass'])?
There was a problem hiding this comment.
Dunno... again I'm on meteor 1.4 so if someone can test on a lower version it would be good. All I know is that this is working for us on 1.4. Tried to account for the other versions. BTW also working fine on galaxy.
|
Thanks! One problem is that this makes Sass non opt-in. I.e. the Is there a pro to rely on the node-sass npm package directly? I can easily fork Chris Butler's node package for Meteor and bump it for 1.4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Meteor 1.4.0.1 Would like to know if anyone out there can give it a shot on 1.3
Also this includes the fix for Modulus production directory (closed previous PR). We have been using this forked version in production since Meteor 1.2 and are getting ready to move from 1.3 to 1.4.0.1
No error in the console:
Test email received: