Skip to content

chore: update node engines to anything 18 or above#997

Merged
dhmlau merged 2 commits into
loopbackio:masterfrom
fabiancook:patch-2
Apr 19, 2025
Merged

chore: update node engines to anything 18 or above#997
dhmlau merged 2 commits into
loopbackio:masterfrom
fabiancook:patch-2

Conversation

@fabiancook
Copy link
Copy Markdown
Contributor

Description

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes (have updated tests to cover additional versions)
  • Code conforms with the style
    guide

Signed-off-by: Fabian Cook <hello@fabiancook.dev>
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 18, 2025

Pull Request Test Coverage Report for Build 14548111183

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.651%

Totals Coverage Status
Change from base Build 14542808791: 0.0%
Covered Lines: 2894
Relevant Lines: 3248

💛 - Coveralls

Copy link
Copy Markdown
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiancook, thanks for your contribution.

@dhmlau
Copy link
Copy Markdown
Member

dhmlau commented Apr 18, 2025

Could you please sign the DCO? Here is the reference: https://loopback.io/doc/en/contrib/code-contrib.html#signing-off-commits-using-dco

… and windows (loopbackio#996)

Signed-off-by: Fabian Cook <hello@fabiancook.dev>
@fabiancook
Copy link
Copy Markdown
Contributor Author

Have updated the most recent commit now.

@dhmlau dhmlau merged commit 3577c01 into loopbackio:master Apr 19, 2025
11 checks passed
@dhmlau
Copy link
Copy Markdown
Member

dhmlau commented Apr 19, 2025

@fabiancook, thanks again for your contribution. Your PR has been merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants