-
Notifications
You must be signed in to change notification settings - Fork 950
[ast] split ast os to power domains #29245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a3f6248 to
9c407a6
Compare
elliotb-lowrisc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems some old typos have been reintroduced, possibly due to some of the typos not being fixed in the source of auto-generated (by a closed-source generator) code.
I have not reviewed the main content of this PR as I do not think I am knowledgeable enough on the AST at this time.
9c407a6 to
72bfe92
Compare
@elliotb-lowrisc Good catch! Just pushed a fix to the AST source :) |
elliotb-lowrisc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked a bit more and found some other things I'm not sure about. Still more to look through, which might be easier if this rather large commit was broken up into smaller ones.
You'll also need to add a sign-off line to the commit/commits as per the contributor guidelines here: https://github.com/lowRISC/opentitan/blob/master/CONTRIBUTING.md
|
I've just this PR with @meisnere. The intention is not to merge this right now but to give people an idea of how the split AST will look like. Having this allows us to do, e.g., the tooling work required for pulling ast into the top(s) (right now the ast is outside of the top, but it will be moved into top_aon and top_main in the future, see RFC: Aon Power Domain Reorganization). Also, we should not merge this PR right now, as it may complicate DV work happening in the closed source right now. For these reasons, I have now converted the PR to draft. |
72bfe92 to
4c98f2a
Compare
4c98f2a to
1f6dcb5
Compare
This PR should be used as a reference when building the new top level structure.
Eventually,
ast_aonshould be under<name>_pd_aon, andast_mainshould be under<name>_pd_mainwhileasthierarchy itself would be deprecated.The PR can be merged as is until top level restructuring is completed.
This PR was tested by the following tests and yielded the same results as before: