Skip to content

Conversation

@meisnere
Copy link

@meisnere meisnere commented Feb 4, 2026

This PR should be used as a reference when building the new top level structure.
Eventually, ast_aon should be under <name>_pd_aon, and ast_main should be under <name>_pd_main while ast hierarchy itself would be deprecated.

The PR can be merged as is until top level restructuring is completed.

This PR was tested by the following tests and yielded the same results as before:

100% pass rate:
  chip_sw_ast_clk_outputs
  chip_sw_clkmgr_reset_frequency 
  chip_sw_clkmgr_sleep_frequency 
  chip_sw_pwrmgr_sleep_sensor_ctrl_alert_wakeup
 
depends on seed:
  chip_sw_sensor_ctrl_alert
 
fails:
  chip_sw_ast_clk_rst_inputs

make -C hw top
make -C hw top_earlgrey_gen

@meisnere meisnere requested a review from a team as a code owner February 4, 2026 13:11
@meisnere meisnere requested review from andreaskurth, glaserf, hcallahan-lowrisc and vogelpi and removed request for a team February 4, 2026 13:11
@meisnere meisnere changed the title [ast_src] split ast os to power domains [ast] split ast os to power domains Feb 4, 2026
Copy link
Contributor

@elliotb-lowrisc elliotb-lowrisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems some old typos have been reintroduced, possibly due to some of the typos not being fixed in the source of auto-generated (by a closed-source generator) code.

I have not reviewed the main content of this PR as I do not think I am knowledgeable enough on the AST at this time.

@meisnere
Copy link
Author

meisnere commented Feb 5, 2026

It seems some old typos have been reintroduced, possibly due to some of the typos not being fixed in the source of auto-generated (by a closed-source generator) code.

I have not reviewed the main content of this PR as I do not think I am knowledgeable enough on the AST at this time.

@elliotb-lowrisc Good catch! Just pushed a fix to the AST source :)

Copy link
Contributor

@elliotb-lowrisc elliotb-lowrisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked a bit more and found some other things I'm not sure about. Still more to look through, which might be easier if this rather large commit was broken up into smaller ones.

You'll also need to add a sign-off line to the commit/commits as per the contributor guidelines here: https://github.com/lowRISC/opentitan/blob/master/CONTRIBUTING.md

@vogelpi vogelpi marked this pull request as draft February 10, 2026 13:58
@vogelpi
Copy link
Contributor

vogelpi commented Feb 10, 2026

I've just this PR with @meisnere. The intention is not to merge this right now but to give people an idea of how the split AST will look like. Having this allows us to do, e.g., the tooling work required for pulling ast into the top(s) (right now the ast is outside of the top, but it will be moved into top_aon and top_main in the future, see RFC: Aon Power Domain Reorganization).

Also, we should not merge this PR right now, as it may complicate DV work happening in the closed source right now.

For these reasons, I have now converted the PR to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants