[otbn, sca] Follow up PR on MAI SCA setup#30687
Open
h-filali wants to merge 4 commits into
Open
Conversation
h-filali
requested review from
timothytrippel
and removed request for
a team and
timothytrippel
h-filali
force-pushed
the
sca-otbn-masc-acc
branch
2 times, most recently
from
755cfcd to
d7730c7
Compare
Contributor
|
CHANGE AUTHORIZED: hw/ip/otbn/rtl/otbn_mask_accelerator.sv This PR removes a parameter from a newly created module to align the SCA verification with how the module is actually used in OTBN. |
Contributor
|
@h-filali , CI / Lint currently fails with: |
Contributor
|
CHANGE AUTHORIZED: hw/ip/otbn/rtl/otbn_mask_accelerator.sv This PR removes a parameter from a newly created module to align the SCA verification with how the module is actually used in OTBN. |
This commit fixes comments where PROLEAD and CocoAlma are not mentioned correctly. Furthermore in README_MAI.md there are some stale references to scripts which are updated in this commit. Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
This commit feeds signals that were hardcoded to a constant out of their modules such that they now have to be applied by the SCA testbench. This aligns the DUT with how it is actually used in OTBN. Furthermore, this commit fixes a bug in a PROLEAD wrapper files and updates the SCA testbenches accordingly. Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
When shortening signal names the shorten_alma_identifiers.py script used to flatten the design before shortening the identifiers. This commit changes this. Now the signal names are shortened without an initial flattening step. This is done by adding a --reserve flag that decides how long the unflattened signal names can get (how much should be left in reserve). Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
h-filali
force-pushed
the
sca-otbn-masc-acc
branch
from
73ff6aa to
1d703d6
Compare
Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up PR that addresses @vogelpi s feedback in #30507