Skip to content

Conversation

@Abi107717
Copy link
Contributor

@Abi107717 Abi107717 commented Jan 22, 2026

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines.
  • I documented the Java code using JavaDoc style.

Motivation and Context

Bulk sending self-scheduling invitations failed with a LazyInitializationException. The async email sender tried to access Job data (title, supervising professor, research group) through the Application entity, but this relation was not eagerly fetched in the repository query.

Description

Added a single line in InterviewService.sendSelfSchedulingInvitations() to manually set the already loaded Job
object on the Application before sending the email

Steps for Testing

(locally)

  1. Log In as a professor
  2. Go to /interviews/overview
  3. Choose a process
  4. Click on Send invitations, check in console that mail was sent
  5. Click on Resend Invitation, check in console mail was sent again

(testserver)

  1. Log In as applicant using your tumID
  2. Apply for a job
  3. Log In as a professor
  4. Go to evaluation, view your application
  5. Go to /interviews/overview
  6. Choose the Process for the Job you applied to
  7. Add yourself to the process
  8. Click on "Send Invitations" button
  9. Verify you got a mail
  10. Click on "Resend Invitation
  11. Verify you got another mail

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Warning: Server tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-22 19:32:35 UTC

@Abi107717 Abi107717 self-assigned this Jan 22, 2026
@Abi107717 Abi107717 requested a review from az108 as a code owner January 22, 2026 17:51
@Abi107717 Abi107717 linked an issue Jan 22, 2026 that may be closed by this pull request
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Jan 22, 2026
@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions github-actions bot added the tests label Jan 22, 2026
@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 OpenAPI spec and client code auto-updated and committed.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 22, 2026
@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

@github-actions github-actions bot removed the tests label Jan 22, 2026
@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 OpenAPI spec and client code auto-updated and committed.

@github-actions github-actions bot removed the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 22, 2026
@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server Pull requests that update Java code. (Added Automatically!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Bulk Invitation not sending emails

2 participants