feat: Add flag to set the timezone on reports #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aVolpe
force-pushed
the
feature/add_flag_to_set_time_entry_timezone
branch
from
c12ae79 to
f422439
Compare
By default all the dates are in UTC, this commit adds a new flag: '--time-zone' or '-z' that allows the user to pass a timezone. This is a breaking change, now, by default the used timezone is 'local', meaning the value returned by 'time.local'. Examples: - Madrid Timezone: -z Europe/Madrid - Current timezone: -z local A full list of timezones can be found here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones This can fix some issues reported in lucassabreu#135. Signed-off-by: Arturo Volpe <[email protected]>
aVolpe
force-pushed
the
feature/add_flag_to_set_time_entry_timezone
branch
from
f422439 to
7446538
Compare
lucassabreu
reviewed
Jan 26, 2024
| @@ -246,6 +246,7 @@ func TestReportWithRange(t *testing.T) { | |||
| }, | |||
| flags: func(t *testing.T) util.ReportFlags { | |||
| rf := util.NewReportFlags() | |||
| rf.TimeZone = "UTC" | |||
There was a problem hiding this comment.
add another entry in the table, but with the following format:
rf.Format = "{{.ID}};{{ .TimeInterval.Start.Format " +
`"2006-01-02 15:04:05"` +
" }}"and a offset timezone so we can see the effect here.
There was a problem hiding this comment.
@lucassabreu thanks for the comments, I have some strange bugs with this feature (the date-filling flag), I will try to fix them this week.
Co-authored-by: Lucas dos Santos Abreu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default all the dates are in UTC, this commit adds a new flag: '--time-zone'
or '-z' that allows the user to pass a timezone.
This is a breaking change, now, by default the used timezone is 'local', meaning
the value returned by 'time.local'.
Examples:
A full list of timezones can be found here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
This can fix some issues reported in #135.
I'm open to fix this PR with your suggestions.
(note that using the time.local timezone is the currently the only option in some report outputs)