-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add flag to set the timezone on reports #253
Merged
lucassabreu
merged 10 commits into
lucassabreu:main
from
aVolpe:feature/add_flag_to_set_time_entry_timezone
Jun 14, 2024
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7446538
feat: Add flag to set the timezone on reports
aVolpe c7ca10a
chore: Apply suggestions from code review
aVolpe 2c19cac
Merge branch 'main' into feature/add_flag_to_set_time_entry_timezone
lucassabreu 91c625e
Merge branch 'main' into feature/add_flag_to_set_time_entry_timezone
lucassabreu 6f7382b
chore: test
lucassabreu 6ce3781
feat: timezone as config
lucassabreu fc1435c
feat: link flag and config
lucassabreu 4255da6
fix: redundant
lucassabreu 7a77a4e
feat: changelog
lucassabreu 2ce6637
fix: time-zone => tz
lucassabreu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add another entry in the table, but with the following format:
and a offset timezone so we can see the effect here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucassabreu thanks for the comments, I have some strange bugs with this feature (the date-filling flag), I will try to fix them this week.