Fix probability slider bugs (0% and upgraded nodes) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed two related bugs: 1. Setting slider to 0% displayed correctly on arrows but calculated as 50% downstream 2. Upgrading intermediate nodes to question nodes didn't affect downstream calculations Root cause: Array-based slider indexing was using questionNodeIndices.indexOf() which found the wrong position when node indices didn't align with slider indices. Changes: - Replace sliderProbs array with Map<string, number> keyed by node ID - Remove buggy questionNodeIndices.indexOf() lookup - Use direct map lookup: nodeIdToProb.get(sourceNode.id) - Fix falsy value bug: change || to ?? so 0 is treated as valid value - Keep sliderIndex field for sidebar visual sorting only Both bugs now resolved and tested. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Resolved conflict in lib/probability.ts: - Keep renamed EdgeType.ALWAYS from main - Keep new Map-based lookup logic from bug fix 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two critical probability slider bugs:
Bug 1: Setting a slider to 0% displayed correctly on arrows but calculated as 50% downstream
||operator treated 0 as falsy, falling back to 50??(nullish coalescing) to only fall back on null/undefinedBug 2: Upgrading intermediate nodes to question nodes - slider affected arrows but not downstream calculations
questionNodeIndices.indexOf()which found wrong position when node indices didn't align with slider indicesMap<string, number>keyed by node ID for direct O(1) lookupsChanges
sliderProbsarray withMap<string, number>keyed by node IDquestionNodeIndices.indexOf()lookupnodeIdToProb.get(sourceNode.id)||→??sliderIndexfield for sidebar visual sorting only (no longer used in calculations)Test Plan
🤖 Generated with Claude Code