Skip to content

Fix probability slider bugs (0% and upgraded nodes) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucbrinkman merged 2 commits into from
Nov 21, 2025
Merged

Fix probability slider bugs (0% and upgraded nodes) #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d509c18
Fix probability slider bugs by using direct node ID lookups
lucbrinkman Nov 21, 2025
895543d
Merge main into probability-bug-fix
lucbrinkman Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions lib/probability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ export function calculateProbabilities(
const edges = initialEdges.map(e => ({ ...e }));

// Extract slider probabilities from question nodes (0-100 to 0.0-1.0)
// Build array indexed by sliderIndex
const sliderProbs: number[] = [];
// Build map from node ID to probability value
const nodeIdToProb = new Map<string, number>();
graphData.nodes.forEach(node => {
if (node.type === NodeType.QUESTION && node.sliderIndex !== null) {
sliderProbs[node.sliderIndex] = (node.probability || 50) / 100.0;
if (node.type === NodeType.QUESTION) {
nodeIdToProb.set(node.id, (node.probability ?? 50) / 100.0);
}
});

Expand Down Expand Up @@ -145,15 +145,14 @@ export function calculateProbabilities(

// Calculate conditional probability based on edge type
if (edge.yn !== EdgeType.ALWAYS) {
// Find the slider index for the source node
const sliderIndex = questionNodeIndices.indexOf(edge.source);
// Get the source node and look up its probability by ID
const sourceNode = nodes[edge.source];
const sliderProb = nodeIdToProb.get(sourceNode.id);

if (sliderIndex === -1) {
throw new Error(`No slider value for node ${edge.source} from edge ${edgeIndex}`);
if (sliderProb === undefined) {
throw new Error(`No slider value for node ${sourceNode.id} (index ${edge.source}) from edge ${edgeIndex}`);
}

const sliderProb = sliderProbs[sliderIndex];

// YES edge = slider probability, NO edge = 1 - slider probability
conditionalProb = edge.yn === EdgeType.YES ? sliderProb : 1.0 - sliderProb;
}
Expand Down