Skip to content

release: 1.20.1#137

Merged
karanganesan merged 8 commits intomainfrom
release-please--branches--main--changes--next--components--lumaai
Mar 7, 2026
Merged

release: 1.20.1#137
karanganesan merged 8 commits intomainfrom
release-please--branches--main--changes--next--components--lumaai

Conversation

@stainless-app
Copy link
Copy Markdown
Contributor

@stainless-app stainless-app Bot commented Feb 20, 2026

Automated Release PR

1.20.1 (2026-03-07)

Full Changelog: v1.20.0...v1.20.1

Bug Fixes

  • client: preserve URL params already embedded in path (bd71801)
  • docs/contributing: correct pnpm link command (35ace89)

Chores

  • ci: skip uploading artifacts on stainless-internal branches (0948668)
  • internal: codegen related update (16451fa)
  • internal: move stringifyQuery implementation to internal function (c8f608f)
  • test: do not count install time for mock server timeout (1905253)
  • update mock server docs (f625696)

This pull request is managed by Stainless's GitHub App.

The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.

For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.

🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions

@cursor
Copy link
Copy Markdown

cursor Bot commented Feb 20, 2026

PR Summary

Medium Risk
Touches core request URL/query construction and retry timing behavior, which could subtly change request URLs or backoff behavior in edge cases; other changes are release/docs/CI plumbing.

Overview
Bumps the SDK to v1.20.1 (manifest/package/version/changelog updates).

Fixes URL construction by preserving query parameters already present in a provided path and merging them with default and per-request query params; stringifyQuery is moved into a new internal utility (src/internal/utils/query.ts) and tests are updated to import it directly.

CI now skips OIDC token retrieval and artifact uploads on stl/* branches, and the mock server script pre-installs Prism and adds a bounded startup wait with clearer timeout failure output; contributing docs are updated accordingly.

Written by Cursor Bugbot for commit 9bd9174. This will update automatically on new commits. Configure here.

@stainless-app
Copy link
Copy Markdown
Contributor Author

stainless-app Bot commented Feb 20, 2026

🧪 Testing

To try out this version of the SDK:

npm install 'https://pkg.stainless.com/s/luma_ai-node/bd718018365cbd54350cb25fec6d4696dd4a4142/dist.tar.gz'

Expires at: Mon, 06 Apr 2026 17:58:11 GMT
Updated at: Sat, 07 Mar 2026 17:58:11 GMT

@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next--components--lumaai branch from 36fa68c to ca53268 Compare February 24, 2026 06:18
@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next--components--lumaai branch from ca53268 to a9fb097 Compare February 27, 2026 07:05
@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next--components--lumaai branch from a9fb097 to 4c89ac2 Compare March 6, 2026 09:23
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Malformed Retry-After causes zero-backoff retry loop
    • Restored validation so malformed, non-positive, or excessively large Retry-After values fall back to exponential default backoff instead of sleeping with zero delay.

Create PR

Or push these changes by commenting:

@cursor push 66268961bc
Preview (66268961bc)
diff --git a/src/core.ts b/src/core.ts
--- a/src/core.ts
+++ b/src/core.ts
@@ -620,7 +620,7 @@
 
     // If the API asks us to wait a certain amount of time, do what it says.
     // Otherwise calculate a default.
-    if (timeoutMillis === undefined) {
+    if (!(timeoutMillis && 0 <= timeoutMillis && timeoutMillis < 60 * 1000)) {
       const maxRetries = options.maxRetries ?? this.maxRetries;
       timeoutMillis = this.calculateDefaultRetryTimeoutMillis(retriesRemaining, maxRetries);
     }

Comment thread src/core.ts
if (!(timeoutMillis && 0 <= timeoutMillis && timeoutMillis < 60 * 1000)) {
// If the API asks us to wait a certain amount of time, do what it says.
// Otherwise calculate a default.
if (timeoutMillis === undefined) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Malformed Retry-After causes zero-backoff retry loop

High Severity

The guard if (timeoutMillis === undefined) no longer protects against NaN or negative timeoutMillis values. When a Retry-After header contains a non-numeric, non-date string, Date.parse() returns NaN, making timeoutMillis NaN. Since NaN !== undefined, the default backoff is skipped and sleep(NaN) is called, which setTimeout treats as 0ms. Similarly, a past date produces a negative value, also treated as 0ms. Both cases cause immediate retries with zero backoff, potentially hammering the server in a tight loop.

Additional Locations (1)

Fix in Cursor Fix in Web

@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next--components--lumaai branch from 4c89ac2 to 5aa407f Compare March 6, 2026 09:50
@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next--components--lumaai branch from 5aa407f to 84ee637 Compare March 7, 2026 17:51
@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next--components--lumaai branch from 84ee637 to 9bd9174 Compare March 7, 2026 17:57
@karanganesan karanganesan merged commit 1dc29f0 into main Mar 7, 2026
11 checks passed
@stainless-app
Copy link
Copy Markdown
Contributor Author

stainless-app Bot commented Mar 7, 2026

🤖 Release is at https://github.com/lumalabs/lumaai-node/releases/tag/v1.20.1 🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant