-
Notifications
You must be signed in to change notification settings - Fork 4
release: 1.20.1 #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
karanganesan
merged 8 commits into
main
from
release-please--branches--main--changes--next--components--lumaai
Mar 7, 2026
Merged
release: 1.20.1 #137
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f625696
chore: update mock server docs
stainless-app[bot] 35ace89
fix(docs/contributing): correct pnpm link command
stainless-app[bot] c8f608f
chore(internal): move stringifyQuery implementation to internal function
stainless-app[bot] 16451fa
chore(internal): codegen related update
stainless-app[bot] 1905253
chore(test): do not count install time for mock server timeout
stainless-app[bot] 0948668
chore(ci): skip uploading artifacts on stainless-internal branches
stainless-app[bot] bd71801
fix(client): preserve URL params already embedded in path
stainless-app[bot] 9bd9174
release: 1.20.1
stainless-app[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| ".": "1.20.0" | ||
| ".": "1.20.1" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // File generated from our OpenAPI spec by Stainless. See CONTRIBUTING.md for details. | ||
|
|
||
| import { LumaAIError } from '../../error'; | ||
|
|
||
| /** | ||
| * Basic re-implementation of `qs.stringify` for primitive types. | ||
| */ | ||
| export function stringifyQuery(query: object | Record<string, unknown>) { | ||
| return Object.entries(query) | ||
| .filter(([_, value]) => typeof value !== 'undefined') | ||
| .map(([key, value]) => { | ||
| if (typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean') { | ||
| return `${encodeURIComponent(key)}=${encodeURIComponent(value)}`; | ||
| } | ||
| if (value === null) { | ||
| return `${encodeURIComponent(key)}=`; | ||
| } | ||
| throw new LumaAIError( | ||
| `Cannot stringify type ${typeof value}; Expected string, number, boolean, or null. If you need to pass nested query parameters, you can manually encode them, e.g. { query: { 'foo[key1]': value1, 'foo[key2]': value2 } }, and please open a GitHub issue requesting better support for your use case.`, | ||
| ); | ||
| }) | ||
| .join('&'); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export const VERSION = '1.20.0'; // x-release-please-version | ||
| export const VERSION = '1.20.1'; // x-release-please-version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Malformed Retry-After causes zero-backoff retry loop
High Severity
The guard
if (timeoutMillis === undefined)no longer protects againstNaNor negativetimeoutMillisvalues. When aRetry-Afterheader contains a non-numeric, non-date string,Date.parse()returnsNaN, makingtimeoutMillisNaN. SinceNaN !== undefined, the default backoff is skipped andsleep(NaN)is called, whichsetTimeouttreats as 0ms. Similarly, a past date produces a negative value, also treated as 0ms. Both cases cause immediate retries with zero backoff, potentially hammering the server in a tight loop.Additional Locations (1)
src/core.ts#L616-L617