Skip to content

No battery icon #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

No battery icon #428

wants to merge 1 commit into from

Conversation

palinek
Copy link
Contributor

@palinek palinek commented Apr 11, 2025

@palinek palinek mentioned this pull request Apr 11, 2025
@stefonarch
Copy link
Member

stefonarch commented Apr 18, 2025

Compiled all on my debian testing PC, works fine from systray. Clicking "disable icon" from right click menu configuration notification shows up and can be accessed. It's disabled ("battery watcher") but the icon actually cannot be disabled in no way, except hiding it always in the tray or disable the moduhttps://github.com//issues/271 le.

So this needs some thinking about, how to handle the disable stuff with that.

  • Disable checkbox of battery watcher and lid where no lid and battery is present? Or not showing them at all in the configuration in those cases? The message "no battery detected" could be removed too then.
  • Idleness checks can be disabled but the menu for pausing them is still active.

Related:
#261

@palinek
Copy link
Contributor Author

palinek commented Apr 22, 2025

Rebased on current master.

So this needs some thinking about, how to handle the disable

Definitely we need to agree when-and-how.

@stefonarch
Copy link
Member

stefonarch commented Apr 28, 2025

I think disabling the icon isn't really needed, usually it's one of the must-have icons in the notify area. Users who wish to suppress it can do that in the settings of the notification area. So we could just remove all of this feature.

Then we just would need to disable/grey out battery|lid watcher when there is none of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants