Refactor input dumping and path retrieval with extension filtering #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mre
commented
Mar 2, 2025
mre
commented
Mar 2, 2025
thomas-zahner
requested changes
May 23, 2025
| // Stop on the first match. | ||
| file_extensions: FileExtensions, | ||
| ) -> impl Stream<Item = Result<InputContent>> { | ||
| ) -> impl Stream<Item = Result<PathBuf>> + '_ { |
There was a problem hiding this comment.
Wouldn't it make sense to update the return type to something like impl Stream<Item = Result<InputSource>> and yield the input sources directly? Then we could also print InputSource::Stdin and the other cases with for example <stdin>. Alternatively, maybe we could introduce a new enum type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
dump-inputsfunctionality to print all files checked for links and implement file path retrieval with extension filtering in theInputmodule.I added this because it was hard to troubleshoot the extension changes, but I figured it would also be helpful to people who want to see which files would be checked when they write
lychee ..As an added benefit,
dump-inputsnow behaves more like thecheckcommand and properly ignores hidden files etc.This is a follow-up to #1559.