Refactor input dumping and path retrieval with extension filtering #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for overwriting extensions: ``` lychee . --extensions md,html,txt,json,yaml ``` The above would only check these extensions. This was enabled by moving to `ignore` (#1500 by @thomas-zahner). Fixes #410
Co-authored-by: Thomas Zahner <[email protected]>
…ved clarity and functionality
… for FileExtensions
…links Follow-up to #1559
mre
commented
Mar 2, 2025
| @@ -333,40 +440,6 @@ impl Input { | |||
| Ok(input_content) | |||
| } | |||
|
|
|||
| fn glob_contents( | |||
There was a problem hiding this comment.
This method was no longer being used.
mre
commented
Mar 2, 2025
Comment on lines
+492
to
+496
| // If the path has no extension, check if we accept plaintext files | ||
| // Note: We treat files without extensions as plaintext | ||
| if path.extension().is_none() { | ||
| return extensions.contains("txt") || extensions.contains(""); | ||
| } |
There was a problem hiding this comment.
This is a bit of a workaround for files without extensions. It works and probably matches the user intent, so I'd argue it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
dump-inputsfunctionality to print all files checked for links and implement file path retrieval with extension filtering in theInputmodule.I added this because it was hard to troubleshoot the extension changes, but I figured it would also be helpful to people who want to see which files would be checked when they write
lychee ..As an added benefit,
dump-inputsnow behaves more like thecheckcommand and properly ignores hidden files etc.This is a follow-up to #1559.