Adding HardSpinner class#23
Open
jviereck wants to merge 1 commit into
Open
Conversation
vincentberenz
approved these changes
Nov 27, 2020
MaximilienNaveau
requested changes
Dec 7, 2020
|
|
||
| void HardSpinner::spin() | ||
| { | ||
| Timer::sleep_until_sec(next_date_sec_); |
Collaborator
There was a problem hiding this comment.
problem:
is 3 tics are missed this method does sleep for 3 times which in a control loop means sending 3 commands without sleeping. Which might mean a robot communication break down.
Collaborator
|
@jviereck do you want to finish this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds another spinner class. This one is similar to the
Spinnerclass. However, it counts the work done into the time budget when computing the time to sleep. In a picture