-
Notifications
You must be signed in to change notification settings - Fork 6
Adding HardSpinner class #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jviereck
wants to merge
1
commit into
master
Choose a base branch
from
jviereck/hard_spinner
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /** | ||
| * @file hard_spinner.cpp | ||
| * @author Julian Viereck (jviereck@tuebingen.mpg.de) | ||
| * license License BSD-3-Clause | ||
| * @copyright Copyright (c) 2020, New York University and Max Planck | ||
| * Gesellschaft. | ||
| * @date 2020-11-26 | ||
| * | ||
| * @brief This file implements a hard spinner to time a loop. Compared to the | ||
| * Spinner class, this spinner uses the desired frequency for how often to | ||
| * spin instead of the desired waiting time. | ||
| * | ||
| * \code{.txt} | ||
| * Spinner: |-----1 ms-----| |-work-| |-----1 ms-----| |-work-| | ||
| * HardSpinner: |-|-work-|-----| |-|-work-|-----| |-|-work-|-----| | ||
| * \endcode | ||
| */ | ||
|
|
||
| #ifndef HARD_SPINNER_HPP | ||
| #define HARD_SPINNER_HPP | ||
|
|
||
| #include <unistd.h> | ||
| #include <chrono> | ||
| #include <real_time_tools/spinner.hpp> | ||
|
|
||
| namespace real_time_tools | ||
| { | ||
| /** | ||
| * @brief Class to have threads / loops running at a desired frequency | ||
| */ | ||
| class HardSpinner: Spinner | ||
| { | ||
| public: | ||
| // create a spinner for the desired frequency | ||
| HardSpinner(); | ||
|
|
||
| /** | ||
| * @brief spin waits for the time such that successive calls to spin | ||
| * will result in spin being called at the desired frequency. | ||
| */ | ||
| void spin(); | ||
| }; | ||
|
|
||
| } // namespace real_time_tools | ||
|
|
||
| #endif // SPINNER_HPP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /** | ||
| * @file hard_spinner.cpp | ||
| * @author Julian Viereck (jviereck@tuebingen.mpg.de) | ||
| * license License BSD-3-Clause | ||
| * @copyright Copyright (c) 2020, New York University and Max Planck | ||
| * Gesellschaft. | ||
| * @date 2020-11-26 | ||
| * | ||
| * @brief This file implements a hard spinner to time a loop. | ||
| */ | ||
|
|
||
| #include <real_time_tools/hard_spinner.hpp> | ||
| #include <real_time_tools/timer.hpp> | ||
|
|
||
| namespace real_time_tools | ||
| { | ||
| HardSpinner::HardSpinner() | ||
| : Spinner() { } | ||
|
|
||
| void HardSpinner::spin() | ||
| { | ||
| Timer::sleep_until_sec(next_date_sec_); | ||
| next_date_sec_ = next_date_sec_ + period_sec_; | ||
| } | ||
|
|
||
| } // namespace real_time_tools | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
problem:
is 3 tics are missed this method does sleep for 3 times which in a control loop means sending 3 commands without sleeping. Which might mean a robot communication break down.