Fixed media folder symlinks

[indykoning]

Description (*)

The new validation gives errors when a situation uses atomic deployments where the media folder is set as a shared folder.

Given some debugging, we can see that the $quoteResolved path resolves the symlink:
/home/www/example.com/shared/pub/media/custom_options/quote

While the $mediaDirectory->getAbsolutePath() does not resolve symlinks:
/home/www/example.com/releases/000/pub/media/

By wrapping it in realPath we force it to resolve those symlinks and we end up comparing
/home/www/example.com/shared/pub/media/custom_options/quote to /home/www/example.com/shared/pub/media/ which is what we want to see in situations with a symlink

Manual testing scenarios (*)

1. Make a symlink from pub/media to somewhere else (e.g. even an external disk)
2. Attempt to add a product option file to your cart
3. See how the Invalid file path. error gets throw.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fixed media folder symlinks #40839: Fixed media folder symlinks

[m2-assistant]

Hi @indykoning. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento create issue

[ihor-sviziev]

@magento run all tests