docs(ci): replace the msstore pin's guess with the actual root cause - #243
Merged
Conversation
The comment added when v1.5.7's Store submit failed blamed v0.4.0's switch to NativeAOT/trimming and an Azure.Storage.Blobs bump. That was wrong. It is microsoft/msstore-cli#162: v0.4.0 added --uploadTimeout with a CustomParser but no DefaultValueFactory. System.CommandLine only invokes a CustomParser when the option is present, so omitting it yields default(long) = 0, which becomes Retry.NetworkTimeout of zero seconds and cancels every request immediately. v0.4.0 and v0.4.1 are both affected; v0.3.9 predates the option entirely. Fixed upstream in #163 (merged 2026-08-25) but not in any release yet, so the pin holds and now says what it is waiting for. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NTm2CAGgE9W54UDimTuwef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment I added when v1.5.7's Store submit failed blamed v0.4.0's switch to NativeAOT + trimming and the
Azure.Storage.Blobs12.25.0 → 12.29.1 bump. That was wrong, and a wrong theory sitting in a pin comment is worse than no theory — the next person to touch this would have chased the build configuration.The real cause is microsoft/msstore-cli#162:
System.CommandLineonly invokes aCustomParserwhen the option is actually present on the command line. Omit it and the value falls back todefault(long)=0, which becomesRetry.NetworkTimeout = TimeSpan.FromSeconds(0)— every request is cancelled the instant it starts, the retry policy burns six attempts, and the upload fails without transferring a byte.Error while uploading the application package.after a consistent ~25s (ours was ~23s), with no stack trace. The real exception only surfaces under--verbose, which also logs the submission's SAS-bearingFileUploadUrl— so it must never run in a public CI log. That is what made it expensive to diagnose from our side.Why the pin stays at v0.3.9
v0.3.9 has neither #154 nor #162 (both were introduced in v0.4.0), and there is nothing else in v0.4.x this workflow needs. Working around #162 by passing
--uploadTimeoutexplicitly would mean carrying someone else's bug by hand for no gain. The comment now says exactly what to wait for: a release later than v0.4.1.Comment-only change; no behaviour difference.